More of a design question, you were doing a quick hack but is there a reason you used so many else if's versus a switch statement? Even a nested switch statement if you really needed it? Other than that pretty schweet for first time jQuery cheers bud and thanks!
@Heledar: DH was overpowered as hell from day 1 on last PTR. In the weeks of testing to follow, Blizzard went on to "fix" DH and increased the gap, and we all know it went live. I can see this going live... Blizzard seems to have given up on releasing a patch in total balance, but want players to find out other ways to restore balance (the barb just came up very late in this patch). Maybe there's something to be found in other classes as well - we'll see as soon as people on PTR have found the new sets and familiarized with the new playstyles. Of course, everyone has perfect DH gear after a season of "play DH or forfeit" which is why on day 1 of this PTR everyone is checking out the DH changes first. (Not true for everyone though - for example, Buleh already cleared GR60 on his barb.)
You're not guaranteed any exposure for your idea here. Even front page featurettes are rare.
Post on the blizzard forums. Especially with the title you have here...even if it is "attention-grabbing" only from your pov, your idea for this particular change is better addressed on a forum with a direct, acknowledged connection to dev eyes and ears. Generating attention here from the community is not the same as garnering attention on the actual forums? Just saying.
Skills that deal Physical damage should no longer benefit from items that increase elemental skill damage.
This removed the bug that allowed weapon-element to affect the damage-type of Physical Skills.
Edited by Druin#1518 on 3/24/2014 12:05 PM PDT
quoted from battle net for the guy that thought skill damage was modded by bonus elemental damage on wep...
Yes, I overlooked CDR from gear for now, but I can add that pretty easily. In the mean time you can just put it into one of the gear slots as a workaround, just only use one cell per amount.
As for toughness, I don't really plan to do anything with the value. EHP is practically the same as toughness anyway, it just doesn't include other affixes like elite reduction and melee/ranged reduction. In the absence of those extra effects, EHP is the same as toughness (though it won't exactly match the in game value for a few reasons that aren't worth getting into unless people are really interested in specifics). In other words, trying to add some amount of toughness to reach some EHP is a bit redundant.
You can play with the extra fields a little and put in elite damage reduction and add some average of melee and ranged reduction to the elite reduction for a better indication of what your toughness would be.
Fair enough, any chance you've gotten contact from Maikyl? He's trying to build on the very similar spreadsheet he developed from your wizard version but I don't see why...why have two pretty much similar spreadsheets when you guys could just work together on what is, in spirit and fact, your spreadsheet? If nothing else, he could give some direction for improvements? I don't know.
I will wait and see how it works now for people and try to add more things like thorns damage and maybe support for more passives.
Why? Did you miss the point that your spreadsheet isn't a significant variation on Loroese's? What is the point of continuing to try and build on your copy of his when you could just significantly contribute to his by working with him? Maintaining this thread seems pointless when you could accomplish more by working with him on new features for the spreadsheet. Please try to get in contact with Loroese through his topic and "merge" (not much is diff) your versions and then go from there?
You've been busy! I see you've added Fervor, and CDR! Great work! Is there a way to equate EHP with Toughness in the spreadsheet, so players can estimate what toughness values they need to hit to reach a given EHP level? i.e. if they're not thinking of a specific item or have it for gear comparison, but realize for instance, "oh, I need to pick up X more toughness with my next two defensive upgrades to reach Y EHP level". Just curious! Again, great work!
Oh and and I believe you overlooked CDR from paragon with the addition of CDR from gear to the spreadsheet!
Thanks Loro, you do a lot for the D3 community and we laud (love?...whoa) you for it!
Skill dmg doesn't show up, always 0, check your formula
Paragon is off...you didn't account for points spent in other categories so it doesn't show the right paragon level, something weird happens with the str/vit stats in the purple areas, this affects strength, armor, health, life everything...
Crit% is off
Crit%Dmg is off
IAS% is off (How could you forget Fervor for the buff 0/1 list?) 15%...
No CDR? One of the most important endgame stats for many builds? What..fervor users get 15% from it too?!
AllRes is off, something to do with how you calculated Extra Res to come up with Avg All Res is weird, I have around 1k res, not 1.7k
Why is your AllRes per socket showing 156 and not 78? Like why is it a sum? Something is really weird with your allres calcs
MH+OH doesn't sum the strength from each slot? MH+OH isn't summed at all? You can't delete the column without changing all the calcs..so make it functional?
Doing "per socket" for stats works but only if you somehow distinguish the wep socket from the rest...so that it multiplies 78*5 sockets for my chest/pants allres, w/o including my 6th socket, which is my CHD emerald in the wep...
Black Areas:
Eff Elite Dmg is showing as a negative value?
Unbuffed dps is showing as a neg value
Something is clearly weird with the Equipped Calcs page for a lot of the "important values"
I think a lot of the issues with the "green" values comes from the paragon issues. I'd start there with your fixes. After that I'd say avg allres calcs are your next issue.
This is just what I noticed from the initial look at it, just trying to help
First of all thank you for spotting all these things.
Now to clarify:
Skill damage is the flat damage you gain from passives, like holy cause, which is shown in game. I understand this can be confusing and will change it to account for skill damage from gear (note that this isn't shown on your character sheet).
Thanks for noting this, this is indeed a stupid mistake and I will fix this.
How exactly are Crit% and Crit Dmg% off?
I have looked through the passives list 3 times and still overlooked this.
I will add CDR to the spreadsheet.
Average All Resist is the average of Extra Resists and Resist All ((all resist*6+extra resistances)/6)
I messed something up here. Will see what I can do to change it.
I will see what I can do here (if you have say 3 diamonds in your chest, 2 diamonds in your legs and 1 ruby in both rings it should divide by 2, not by 4).
Eff Elite Dmg and Unbuffed dps doesn't show as a negative number on my end.
Could you post a link to your armory? With my own values it shows no actual issues.
I also intend to add more stats to account for the "new" stats, like area damage and resource cost reduction. I want this spreadsheet to show pretty much all information you also have in game and be able to compare items more precisely.
My battlenet name is in my icon?
But honestly like it's not even worth it at this point. Loroese's Crusader version of his own spreadsheet is superior in every way. And I mean you've pretty much just unknowingly redone all the work he had already done anyways. I don't mean to belittle the work you did retooling a lot of the spreadsheet to go from Wizard to Crusader, but honestly I don't really think there's a point going back to fix all the errors in your version when his already works "out of the box". Instead maybe join his thread and pair up with him to help expand his original version of the spreadsheet to include more information (like Fervor, CDR, dmg reduction/etc.)? I'm sorry. It is what it is. You had a good thought in expanding on his work for Wizards (to give something to the Crusader community) but it's not like you could have known he had a Crusader version already started.
Again, thanks for your effort, but definitely get in contact with Loroese.
I'd def add a CDR row, even if you can't factor it into relative dps gains, you could set it up for people trying to reach the AC breakpoints. Fervor is the only thing that should prob be added to that effect (as it's a flat CDR/AS passive), the other passive buffs are specific skill %dmg increases or cool down reductions, and adding them in would take time and testing I think. But just having a way to sum CDR effectively across gear with or without Fervor within the spreadsheet would probably be helpful. That's all I have for now. Your spreadsheet is pretty much perfect otherwise and functions exceedingly well for multi-item comparisons/etc. should def make a new thread for it, no offense to Maikyl! Anyways cheers, I'm off to enjoy my Friday night!
It still needs a couple tweaks, but if you want to use it to try and fix yours, feel free. I'll probably post itin a separate thread later over the weekend.
I added Fervor to his version of your spreadsheet (at least attack speed wise) by adding the string "+'Equipped Items'!U17*15 " to the end of the appropriate field in the Equipped Calculations page for attack speed. Not sure if you'd care to add it to yours with changed U-field before you repost it in the separate thread but considering a lot of FoTH Crusaders are running Darklight it might be helpful for them. Just a thought! Have a great weekend and thanks for all your work for the community!
Skill dmg doesn't show up, always 0, check your formula
Paragon is off...you didn't account for points spent in other categories so it doesn't show the right paragon level, something weird happens with the str/vit stats in the purple areas, this affects strength, armor, health, life everything...
Crit% is off
Crit%Dmg is off
IAS% is off (How could you forget Fervor for the buff 0/1 list?) 15%...
No CDR? One of the most important endgame stats for many builds? What..fervor users get 15% from it too?!
AllRes is off, something to do with how you calculated Extra Res to come up with Avg All Res is weird, I have around 1k res, not 1.7k
Why is your AllRes per socket showing 156 and not 78? Like why is it a sum? Something is really weird with your allres calcs
MH+OH doesn't sum the strength from each slot? MH+OH isn't summed at all? You can't delete the column without changing all the calcs..so make it functional?
Doing "per socket" for stats works but only if you somehow distinguish the wep socket from the rest...so that it multiplies 78*5 sockets for my chest/pants allres, w/o including my 6th socket, which is my CHD emerald in the wep...
Black Areas:
Eff Elite Dmg is showing as a negative value?
Unbuffed dps is showing as a neg value
Something is clearly weird with the Equipped Calcs page for a lot of the "important values"
I think a lot of the issues with the "green" values comes from the paragon issues. I'd start there with your fixes. After that I'd say avg allres calcs are your next issue.
This is just what I noticed from the initial look at it, just trying to help
Hey Baggins de Stone,
More of a design question, you were doing a quick hack but is there a reason you used so many else if's versus a switch statement? Even a nested switch statement if you really needed it? Other than that pretty schweet for first time jQuery
cheers bud and thanks!
I love it
You're not guaranteed any exposure for your idea here. Even front page featurettes are rare.
Post on the blizzard forums. Especially with the title you have here...even if it is "attention-grabbing" only from your pov, your idea for this particular change is better addressed on a forum with a direct, acknowledged connection to dev eyes and ears. Generating attention here from the community is not the same as garnering attention on the actual forums? Just saying.
ok
http://us.battle.net/d3/en/forum/topic/12032813274
The following change was made --
This removed the bug that allowed weapon-element to affect the damage-type of Physical Skills.
Edited by Druin#1518 on 3/24/2014 12:05 PM PDT
quoted from battle net for the guy that thought skill damage was modded by bonus elemental damage on wep...
http://www.diablofans.com/forums/diablo-iii-class-forums/crusader-the-church-of-zakarum/88848-crusader-dps-and-ehp-spreadsheet
You're not doing anyone any favors by trying to maintain your spreadsheet as separate from his...how much more simply can I explain this?
It's Kapsu...I mean
How is Fire Starter your main source of damage when you stack +lightning?
Why are you so defensive?! It's?! A gaming forum?!
Just what.
You've been busy! I see you've added Fervor, and CDR! Great work! Is there a way to equate EHP with Toughness in the spreadsheet, so players can estimate what toughness values they need to hit to reach a given EHP level? i.e. if they're not thinking of a specific item or have it for gear comparison, but realize for instance, "oh, I need to pick up X more toughness with my next two defensive upgrades to reach Y EHP level". Just curious! Again, great work!
Oh and and I believe you overlooked CDR from paragon with the addition of CDR from gear to the spreadsheet!
Thanks Loro, you do a lot for the D3 community and we laud (love?...whoa) you for it!
But honestly like it's not even worth it at this point. Loroese's Crusader version of his own spreadsheet is superior in every way. And I mean you've pretty much just unknowingly redone all the work he had already done anyways. I don't mean to belittle the work you did retooling a lot of the spreadsheet to go from Wizard to Crusader, but honestly I don't really think there's a point going back to fix all the errors in your version when his already works "out of the box". Instead maybe join his thread and pair up with him to help expand his original version of the spreadsheet to include more information (like Fervor, CDR, dmg reduction/etc.)? I'm sorry. It is what it is. You had a good thought in expanding on his work for Wizards (to give something to the Crusader community) but it's not like you could have known he had a Crusader version already started.
Again, thanks for your effort, but definitely get in contact with Loroese.
Green Areas:
- Skill dmg doesn't show up, always 0, check your formula
- Paragon is off...you didn't account for points spent in other categories so it doesn't show the right paragon level, something weird happens with the str/vit stats in the purple areas, this affects strength, armor, health, life everything...
- Crit% is off
- Crit%Dmg is off
- IAS% is off (How could you forget Fervor for the buff 0/1 list?) 15%...
- No CDR? One of the most important endgame stats for many builds? What..fervor users get 15% from it too?!
- AllRes is off, something to do with how you calculated Extra Res to come up with Avg All Res is weird, I have around 1k res, not 1.7k
- Why is your AllRes per socket showing 156 and not 78? Like why is it a sum? Something is really weird with your allres calcs
- MH+OH doesn't sum the strength from each slot? MH+OH isn't summed at all? You can't delete the column without changing all the calcs..so make it functional?
- Doing "per socket" for stats works but only if you somehow distinguish the wep socket from the rest...so that it multiplies 78*5 sockets for my chest/pants allres, w/o including my 6th socket, which is my CHD emerald in the wep...
Black Areas:- Eff Elite Dmg is showing as a negative value?
- Unbuffed dps is showing as a neg value
- Something is clearly weird with the Equipped Calcs page for a lot of the "important values"
I think a lot of the issues with the "green" values comes from the paragon issues. I'd start there with your fixes. After that I'd say avg allres calcs are your next issue.This is just what I noticed from the initial look at it, just trying to help